Implement Peer ID Verification within Noise Protocol Handshake Instead of Connection Pool Poll

[frystal]

Summary

In the rust-libp2p Noise protocol implementation, when the current node operates as an initiator for the handshake, it fails to verify if the remote connection has the same public key as the node it is attempting to dial.
https://github.com/libp2p/rust-libp2p/blob/master/transports/noise/src/lib.rs#L158

Instead, the node ID validation is performed during the connection pool stage when the "PendingConnectionEvent::ConnectionEstablished" event is triggered. https://github.com/libp2p/rust-libp2p/blob/master/swarm/src/connection/pool.rs#L675

I am concerned that this approach might be inadequate, as the connection information has already been logged into the swarm by this point. Thus it might potentially increase the risk to identity theft attacks. While I am relatively new to Rust, I observed that in both go-libp2p and js-libp2p, this check is performed during the Noise protocol stage, and the connection is not established if an inconsistency in the peer ID is detected. I would be grateful to be told the reasoning behind conducting this check later in the connection pool.

Expected behavior

The peer ID verification should take place during the Noise protocol handshake stage, and the connection should be rejected if the peer ID is not consistent with expectations, all before the "PendingConnectionEvent::ConnectionEstablished" event is triggered.

Actual behavior

The peer ID check is currently conducted in the swarm pool after the Noise protocol handshake has been established.

Relevant log output

No response

Possible Solution

No response

Version

No response

Would you like to work on fixing this bug ?

Maybe

[thomaseizinger]

You are fully correct in your analysis! I am going to close this as a dupe of #2946 :)