Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tokio feature adds libp2p-quic to dependencies #5629

Closed
nazar-pc opened this issue Oct 9, 2024 · 1 comment
Closed

tokio feature adds libp2p-quic to dependencies #5629

nazar-pc opened this issue Oct 9, 2024 · 1 comment

Comments

@nazar-pc
Copy link
Contributor

nazar-pc commented Oct 9, 2024

Summary

tokio feature unconditionally introduces libp2p-quic dependency for unknown reason.

Consider following:

[dependencies.libp2p]
version = "0.54.1"
default-features = false
features = [
    "tokio",
    "yamux",
]

This way libp2p-quic is present in libp2p dependencies, if tokio feature is removed then libp2p-quic is no longer present.

Expected behavior

Only components explicitly requested are added to dependencies

Actual behavior

See summary

Relevant log output

No response

Possible Solution

No response

Version

0.52.4 (still used by Substrate, hence relevance), 0.54.1

Would you like to work on fixing this bug ?

Yes

@nazar-pc
Copy link
Contributor Author

Apparently it is a Cargo issue 😞: rust-lang/cargo#10801

@nazar-pc nazar-pc closed this as not planned Won't fix, can't repro, duplicate, stale Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant