Changed alignment of options in descriptions. #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @cage2, Thanks for the pull request! I'll look at it in the next few days! |
|
On Sun, Apr 19, 2020 at 09:50:16AM -0700, Thomas Schaper wrote:
Hi @cage2,
Hi!
Thanks for the pull request! I'll look at it in the next few days!
Thank you very much for your work and your quick reply! :)
Bye!
C.
|
digikar99
added a commit
to digikar99/unix-opts
that referenced
this pull request
May 22, 2020
opts::print-opts can definitely still improve libre-man#21
libre-man
added a commit
that referenced
this pull request
May 23, 2020
Thanks to @cage2 for this change, this improves the way the options are aligned when displayed using `DESCRIBE`.
libre-man
reviewed
May 23, 2020
| (with-output-to-string (s) | ||
| (when newline | ||
| (format s "~&~a" pad)) | ||
| (format s "~%~a" pad)) |
There was a problem hiding this comment.
This used to only output a newline when the output wasn't already at a newline, however as this is an empyt stream (we just created it on line 399) this would never output a newline.
libre-man
added a commit
that referenced
this pull request
May 23, 2020
Thanks to @cage2 for this change, this improves the way the options are aligned when displayed using `DESCRIBE`.
libre-man
added a commit
that referenced
this pull request
May 23, 2020
Thanks to @cage2 for this change, this improves the way the options are aligned when displayed using `DESCRIBE`.
|
On Sat, May 23, 2020 at 03:08:29AM -0700, Thomas Schaper wrote:
@libre-man commented on this pull request.
Hi!
Thanks for the changes, I've merged it in e14c9b5 after doing some
minor changes and adding some tests!
Thanks to you for your review and clearing my doubts about the format
directive! :)
Bye!
C.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I found the alignment of option's description a bit messed up honestly.
I tried to fix that, i tested with long meta argument or with descriptions that included newlines and seems OK to me.
The only thing i can not understand is why i had to change the directive "
&" to "%" to make things works.I am open to critics and review for this patch (i mean, more than usual!).
Bye!
C.