-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev #26
base: master
Are you sure you want to change the base?
Dev #26
Conversation
…is another longer option of the form --option-long.
In Allegro CL, the symbol `sys:command-line-arguments' is a function and must be called in order to correctly access command line arguments.
Reference: https://stackoverflow.com/questions/52674349/c17-code-not-compiling-on-travis-with-clang-6-0 Travis uses Ubuntu 14.04 which does not have libstdc++-7-*
Issue filed at: Clozure/ccl#304
failing test refers to libre-man#22
opts::print-opts can definitely still improve libre-man#21
libre-man#20 Added allegro to .travis as well
While I had attempted |
Hi thanks @digikar99 for the extensive fixes! I will cherry pick/manually extract the features from it one by one if that is ok by you. The first one I've done was improving the testing in #27. In the next few days I'll extract the macro for the shorter definition of the options. |
Yes that's perfectly okay; if anything, the way it has been done with the recent PR is much better than what I had attempted. |
Looks like most of the things have been merged. Two of the things that seem to remain include |
I'm still planning on merging them, but I haven't had time for it just yet, also because it needs quite some work to split them up especially as the master now contains some of the functionality already of this PR. I'll probably have some time this weekend to get started on it again, so hopefully I'll be able to merge the |
I'd be willing to close this PR - this looks pretty dirty anyways - and perhaps issue a separate PR explicitly for the |
I guess the commits mostly cover all the changes; those that do not seem well mentioned include -
unix-opts-tests
is renamed tounix-opts/tests
; and(unix-opts/tests:run)
runs the tests; there is some test refactoring as well;fiveam
,local-nicknames
,asdf:test-op
are not supported on all implementations (clisp in particular); hence, cannot be used.I am not sure about the versioning conventions, but the change on adding
ambiguous-option
condition might be significant enough for some people to demand a version bump.