Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subtitles have incomplete names #4680

Closed
3 tasks done
solimm4sks opened this issue Sep 1, 2023 · 3 comments
Closed
3 tasks done

Subtitles have incomplete names #4680

solimm4sks opened this issue Sep 1, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@solimm4sks
Copy link

Steps to reproduce

Look at the subtitles in this video: https://www.youtube.com/watch?v=GroV8G4Amg8 . On LibreTube they are called: None, English, English, (some japanese characters i cant read). On Youtube they are called: Off, English, English - Neobrane, Japanese (auto-generated).

The ones on the youtube client are much more descriptive.

Expected behavior

The subtitle (caption) track name is the same on LibreTube as it is on Youtube.

Actual behavior

It's not. It's less descriptive.

LibreTube version

0.16.1

Android version

10

Other details

I especially have gripes with "English - Neobrane" being turned into "English", since that makes it hard to differentiate between the two English tracks.

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
  • I have written a short but informative title.
  • I will fill out all of the requested information in this form.
@solimm4sks solimm4sks added the bug Something isn't working label Sep 1, 2023
@Bnyro
Copy link
Member

Bnyro commented Sep 1, 2023

https://piped.video/watch?v=GroV8G4Amg8 shows the same captions as LibreTube, thus it's either not supported by the Piped backend or the NewPipe Extractor to extract the extended language name.

The caption names in LibreTube are the ones returned by the Piped backend.

@Bnyro Bnyro closed this as not planned Won't fix, can't repro, duplicate, stale Sep 1, 2023
@Bnyro
Copy link
Member

Bnyro commented Sep 4, 2023

I can confirm it's a NewPipe Extractor issue.

@absidue
Copy link

absidue commented Sep 30, 2023

@Bnyro This is highly likely to be a bug on your side not NewPipeExtractor, so I suggest you reopen this.

On Piped it's because they haven't configured shaka-player to use the label, so it defaults to displaying the name of the language instead, also shaka-player deduplicates based on language and role, which is why it is only showing one of the tracks. (look at the trackLabelFormat option, which Piped doesn't set: https://shaka-player-demo.appspot.com/docs/api/shaka.extern.html#.UIConfiguration)

This is probably a configuration issue on your side too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants