Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tokio migration] Proxy support #653

Closed
Johannesd3 opened this issue Feb 25, 2021 · 1 comment
Closed

[Tokio migration] Proxy support #653

Johannesd3 opened this issue Feb 25, 2021 · 1 comment

Comments

@Johannesd3
Copy link
Contributor

Proxy support was one of the few things that weren't easy to migrate to tokio 1.0, mainly because hyper-proxy is not migrated yet. While #583 added basic proxy support again, it was only tested with a quickly set up local proxy server instance. In the discussion of this PR, 3 alternatives came up (read there for their advantages an drawbacks):

  1. Using the simple proxytunnel
  2. Waiting for hyper-proxy
  3. Using reqwest

Since I don't know anything about proxy servers (and don't need them), I would appreciate if someone else takes a look at it.

@sashahilton00 Would it be possible to use milestones or custom labels to keep track of the issues related to the tokio migration?

@Johannesd3
Copy link
Contributor Author

They did update hyper-proxy, so we can make progress here.

BTW, while re-implementing proxy support I did not really care for the format of addresses (e.g. whether port or protocol are specified), I think the behaviour could differ compared to before. We should check this.

@Johannesd3 Johannesd3 mentioned this issue Mar 8, 2021
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants