Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broadcasts: Disabling "Results" should hide them from single-board view #16786

Open
AAArmstark opened this issue Jan 16, 2025 · 4 comments
Open
Labels
broadcasts improvement Small incremental improvement to an existing feature

Comments

@AAArmstark
Copy link
Contributor

Disabling the recently introduced broadcast "Results" option (#16650) doesn't hide the results from the single-board game view, so users cannot play through any moves without seeing the results again, defeating the purpose of the option.

For example: https://lichess.org/broadcast/prague-open-2025--im-open/round-8/sxGrKfFM/76zCqJGq

Image

Image

Instead, the result could be displayed only on (or after) the final move, or it could always be hidden, but the user would then need another button in the single-board game view to display the result whenever they want (without going back to the multi-board view).

@SergioGlorias SergioGlorias added improvement Small incremental improvement to an existing feature broadcasts labels Jan 16, 2025
@yafred
Copy link
Contributor

yafred commented Jan 17, 2025

Same for the PGN ? It's a spoiler too ?

@AAArmstark
Copy link
Contributor Author

  • moves in the notation could only become visible after the user made them on the board (similar to the "hide next moves" study analysis mode)
    so instead of this: Image
    we would have this: Image

  • analysis, annotations, arrows could be disabled automatically (users can already do that themselves though)
    Image

  • variations could be removed as they spoiler that the player made a mistake
    Image

  • pgn tags and computer analysis buttons could be removed from the bar below the board
    Image

(and I realized that the multi-board view below the board already allows to toggle the results, so a new button, as I suggested before, might not be needed)
Image

@SergioGlorias
Copy link
Member

maybe hiding the moves will be a bit tricky, but hiding the result until the last move would help

@yafred
Copy link
Contributor

yafred commented Jan 18, 2025

@SergioGlorias I am reading the code at the moment and I think there may be a way to add to the extend the Conceal concept to achieve what I think @AAArmstark would expect

The way I see it, when you have unchecked the 'show results' box:

  • Clicking on a board in the multiboard area would open the 'game' (actually the study chapter) at the initial position with the moves hidden and the result hidden (in the player headers)
  • Clicking on 'jump next' would unroll the moves and unveil them in the side view (which is not possible without extending the Conceal implementation)
  • When you reach the last move (either jump next or jump last), the result would appear

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
broadcasts improvement Small incremental improvement to an existing feature
Projects
None yet
Development

No branches or pull requests

3 participants