Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Open containing folder" should highlight the file in the containing folder if opening a single-file torrent #104

Closed
lighterowl opened this issue Sep 3, 2024 · 5 comments · Fixed by #106
Labels
base-transgui-bug Has a corresponding issue in base transgui repo bug Something isn't working os:lnx os:mac
Milestone

Comments

@lighterowl
Copy link
Owner

Originally reported by @devnoname120 in #101 .

If I click on Open containing folder on a single-file torrent (audiobook.m4b) then it opens Finder on the directory of all completed files (in my case /mnt/torrents/completed) without highlighting the specific one that I was looking for, so I have to scan the list of files in the directory myself or use the search to find audiobook.m4b. It would be nice if it were highlighted in the Finder window that transgui opens.

I can see the same behaviour under Linux+xfce+Thunar, but not Windows, where the file is highlighted in the new Explorer window.

@lighterowl lighterowl added bug Something isn't working os:mac os:lnx labels Sep 3, 2024
@lighterowl
Copy link
Owner Author

macOS solution is in https://stackoverflow.com/questions/7652928/launch-finder-window-with-specific-files-selected , see if I can figure out how to call the ObjC function, otherwise settle on open -R.

@lighterowl
Copy link
Owner Author

Doing the same on Linux will require making a DBus call to something implementing https://www.freedesktop.org/wiki/Specifications/file-manager-interface/ .

@devnoname120
Copy link

macOS solution is in stackoverflow.com/questions/7652928/launch-finder-window-with-specific-files-selected , see if I can figure out how to call the ObjC function, otherwise settle on open -R.

Awesome, thanks for looking into it :)

@lighterowl
Copy link
Owner Author

Open containing folder will now always show the containing folder of the given item in the platform's local file manager, with the item - whether a folder or a file - highlighted in that folder. This applies to individual torrents in the program's main table as well as their contents in the Files tab.

@lighterowl lighterowl added this to the 5.18.8 milestone Sep 24, 2024
@lighterowl
Copy link
Owner Author

@lighterowl lighterowl added the base-transgui-bug Has a corresponding issue in base transgui repo label Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
base-transgui-bug Has a corresponding issue in base transgui repo bug Something isn't working os:lnx os:mac
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants