[bug]: tapd creates an invoice that expires after the quote from the oracle expires

[ZZiigguurraatt]

On my price oracle I have a expiry_timestamp set to 300 seconds in the future.

I then create an invoice and don't set the expiry in order to accept the default expiry of 86400 seconds.

tapd happily generates the invoice, but I think it should fail.

price oracle expiration time should always be after invoice expiration time.

[Roasbeef]

Makes sense, when we get the RFQ response/accept back, we should use that to set a custom expiry on the invoice.

[ZZiigguurraatt]

Makes sense, when we get the RFQ response/accept back, we should use that to set a custom expiry on the invoice.

One thing I was getting ready to test is do you already do this and I just don't know that I you've reduced the expiry from 86400 seconds to 300 seconds without telling me?

I think the user must have their sats invoice expiry honored and not overridden by a lower quote expiry. If that is the case there are going to be a lot of problems at the application level. If the price quote expiry is less than the invoice expiry, it should error.