Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature]: Remove rounding of fees after bumping to LND v0.19.0 #1355

Open
gijswijs opened this issue Feb 5, 2025 · 0 comments
Open

[feature]: Remove rounding of fees after bumping to LND v0.19.0 #1355

gijswijs opened this issue Feb 5, 2025 · 0 comments
Assignees
@gijswijs
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request lnd

Comments

@gijswijs
Copy link
Contributor

gijswijs commented Feb 5, 2025

LND will introduce support for sat_per_kw with the FundPsbt RPC endpoint in v0.19.0. (See: lightningnetwork/lnd#9013)

We could use this in tapd which would remove the need for rounding up fees to keep them above the min_relay_fee. This rounding fix was introduced with #1354.

This issue is a todo for once v0.19.0 is released.

Be careful to also bump the minimum version or make the rounding dependent on the version of lnd being used.
@gijswijs gijswijs added dependencies Pull requests that update a dependency file enhancement New feature or request lnd labels Feb 5, 2025
@gijswijs gijswijs self-assigned this Feb 5, 2025
@levmi levmi moved this from 🆕 New to 👀 In review in Taproot-Assets Project Board Feb 11, 2025
@levmi levmi moved this from 👀 In review to 🆕 New in Taproot-Assets Project Board Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gijswijs gijswijs

Labels
dependencies Pull requests that update a dependency file enhancement New feature or request lnd
Projects
Taproot-Assets Project Board
Status: 🆕 New
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gijswijs