You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Per planning discussion yesterday, we want to enable the enforcement of offers within the RFQ system. Currently, we can register basic offers with the RFQ system via RPC. However, these offer limitations are not actually enforced. This is evident in the following commented-out code:
// If we do not have a suitable buy offer, then we will reject
// the asset sell quote request with an error.
// reject := rfqmsg.NewReject(
// request.Peer, request.ID,
// rfqmsg.ErrNoSuitableBuyOffer,
// )
// go sendOutgoingMsg(reject)
//
// return nil
}
This lack of enforcement applies to both buy and sell offers.
We'd like to take the initial step towards enforcing those offers. It's also worth noting that the RFQ counterparty is currently unaware of these offers. They serve purely as a local mechanism for asset channel management in relation to RFQ.
So, the minimum initial step is uncommenting the code
// If we do not have a suitable buy offer, then we will reject
// the asset sell quote request with an error.
// reject := rfqmsg.NewReject(
// request.Peer, request.ID,
// rfqmsg.ErrNoSuitableBuyOffer,
// )
// go sendOutgoingMsg(reject)
//
// return nil
}
here so that we avoid a dead RPC endpoint. Then, related to #1362, we can think carefully about the path forward to enable the functionality that we want.
The text was updated successfully, but these errors were encountered:
Per planning discussion yesterday, we want to enable the enforcement of offers within the RFQ system. Currently, we can register basic offers with the RFQ system via RPC. However, these offer limitations are not actually enforced. This is evident in the following commented-out code:
taproot-assets/rfq/negotiator.go
Lines 407 to 427 in 89891ee
We'd like to take the initial step towards enforcing those offers. It's also worth noting that the RFQ counterparty is currently unaware of these offers. They serve purely as a local mechanism for asset channel management in relation to RFQ.
So, the minimum initial step is uncommenting the code
taproot-assets/rfq/negotiator.go
Lines 407 to 427 in 89891ee
The text was updated successfully, but these errors were encountered: