Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility issue with Twig #1272

Closed
emulienfou opened this issue Mar 24, 2020 · 1 comment
Closed

Compatibility issue with Twig #1272

emulienfou opened this issue Mar 24, 2020 · 1 comment

Comments

@emulienfou
Copy link
Contributor

Since the version 2.2 of this bundle, in the next template file Resources/views/Form/form_div_layout.html.twig you made a change from using the Twig tag spaceless to apply spaceless.

However, this new tag has been added from Twig versions 1.40, 2.9 and 3.0. But in your composer.json you didn't require a specific version for the package twig/twig.

So I had an example with an old project who are using Twig ~1.35.0 with Symfony 4.4 and since there is no requirement for Twig package, the version 2.2 of liip/imagine-bundle has been installed and generate an issue, because the tag apply in not existing in this Twig version.

I think you should specify a twig requirement version for the package twig/twig, such as:
"twig/twig": "^1.40|^2.9|^3.0".

@franmomu
Copy link
Contributor

Thanks for reporting this! Can you please submit a PR fixing this? I would add it to the conflict section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants