Issue with path on Windows?

[yellow1912]

In Liip\ImagineBundle\Binary\Loader\FileSystemLoader

we have:
$absolutePath = $this->rootPath.'/'.ltrim($path, '/');

On Windows, we will get something like:
/D:/absolute/path

Is this intentional or should it be something like:
$absolutePath = ltrim($path, '/');

[trsteel88]

@yellow1912, the ltrim is simply trimming the $path so you don't end up with root-path//absolute-path (notice the //). From memory, the root path would normally be the absolute path to the cache directory. (eg D:/Application/web/media/cache/)

Therefore the final path would be D:/Application/web/media/cache/filename.jpg

[vinhtrinh]

Using factory instead liip_imagine.binary.loader.prototype.filesystem directly:

liip_imagine:
    loaders:
        image:
            filesystem:
                data_root: %kernel.root_dir%/../web/assets/images

Now, your actual service is: liip_imagine.binary.loader.image and use this loader to find a relative path, not an absolute.

But if an user don't care about rootPath. So, they can use the prototype above and find an absolute path. A little check on rootPath is nice

$absolutePath = (empty($this->rootPath) ? '' : $this->rootPath . '/') . ltrim($path, '/');

[michellesanver]

@yellow1912 Did vinhtrinh's solve your issue? If not, please open a new issue if this is still an issue for you. Thanks! :)