From ed5611b046c2130d3d3e6c5c0872bd79c896e8bc Mon Sep 17 00:00:00 2001
From: Scott Huberty <52462026+scott-huberty@users.noreply.github.com>
Date: Fri, 26 Jul 2024 09:24:21 -0700
Subject: [PATCH] MAINT: Remove pytest.mark.filterwarnings(FutureWarnings)
 (#166)

* MAINT: remove warning filters

Now that MNE ICALABEL .7 is out, which has my upstream fix, we should no longer need these futurewarnings as long as the CI's install .7

* FIX: remove stale GHA workflow

- This workflow inadverdently got committed in #161 i.e. it shoudl never have entered the codebase on main.
---
 .github/workflows/main_pylossless-qc-demo.yml | 63 -------------------
 pylossless/conftest.py                        |  3 -
 pylossless/tests/test_rejection.py            |  2 -
 3 files changed, 68 deletions(-)
 delete mode 100644 .github/workflows/main_pylossless-qc-demo.yml

diff --git a/.github/workflows/main_pylossless-qc-demo.yml b/.github/workflows/main_pylossless-qc-demo.yml
deleted file mode 100644
index 04b2245..0000000
--- a/.github/workflows/main_pylossless-qc-demo.yml
+++ /dev/null
@@ -1,63 +0,0 @@
-# Docs for the Azure Web Apps Deploy action: https://github.com/Azure/webapps-deploy
-# More GitHub Actions for Azure: https://github.com/Azure/actions
-# More info on Python, GitHub Actions, and Azure App Service: https://aka.ms/python-webapps-actions
-
-name: Build and deploy Python app to Azure Web App - pylossless-qc-demo
-
-on:
-  push:
-    branches:
-      - main
-  workflow_dispatch:
-
-jobs:
-  build:
-    runs-on: ubuntu-latest
-
-    steps:
-      - uses: actions/checkout@v2
-
-      - name: Set up Python version
-        uses: actions/setup-python@v1
-        with:
-          python-version: '3.7'
-
-      - name: Create and start virtual environment
-        run: |
-          python -m venv venv
-          source venv/bin/activate
-      
-      - name: Install dependencies
-        run: pip install -r requirements.txt
-        
-      # Optional: Add step to run tests here (PyTest, Django test suites, etc.)
-      
-      - name: Upload artifact for deployment jobs
-        uses: actions/upload-artifact@v2
-        with:
-          name: python-app
-          path: |
-            . 
-            !venv/
-
-  deploy:
-    runs-on: ubuntu-latest
-    needs: build
-    environment:
-      name: 'Production'
-      url: ${{ steps.deploy-to-webapp.outputs.webapp-url }}
-
-    steps:
-      - name: Download artifact from build job
-        uses: actions/download-artifact@v2
-        with:
-          name: python-app
-          path: .
-          
-      - name: 'Deploy to Azure Web App'
-        uses: azure/webapps-deploy@v2
-        id: deploy-to-webapp
-        with:
-          app-name: 'pylossless-qc-demo'
-          slot-name: 'Production'
-          publish-profile: ${{ secrets.AZUREAPPSERVICE_PUBLISHPROFILE_B1F7B3988A884792AC90F3E962E01A2B }}
diff --git a/pylossless/conftest.py b/pylossless/conftest.py
index 8a63307..a6ae964 100644
--- a/pylossless/conftest.py
+++ b/pylossless/conftest.py
@@ -14,9 +14,6 @@
 import pytest
 
 
-# XXX: This is a temporary fix to suppress a warning from MNE-ICAlabel
-# This can be removed once MNE-ICAlabel 0.7 is released
-@pytest.mark.filterwarnings("ignore::FutureWarning")
 @pytest.fixture(scope="session")
 def pipeline_fixture():
     """Return a namedTuple containing MNE eyetracking raw data and events."""
diff --git a/pylossless/tests/test_rejection.py b/pylossless/tests/test_rejection.py
index 8a775d9..478b71d 100644
--- a/pylossless/tests/test_rejection.py
+++ b/pylossless/tests/test_rejection.py
@@ -7,8 +7,6 @@
 import pylossless as ll
 
 
-# XXX: This filter can be removed once MNE-ICAlabel 0.7 is released
-@pytest.mark.filterwarnings("ignore::FutureWarning")
 @pytest.mark.parametrize("clean_ch_mode", [None, "drop", "interpolate"])
 def test_rejection_policy(clean_ch_mode, pipeline_fixture):
     """Test the rejection policy."""