Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration/interoperability with autoreject #202

Open
christian-oreilly opened this issue Dec 11, 2024 · 1 comment
Open

Integration/interoperability with autoreject #202

christian-oreilly opened this issue Dec 11, 2024 · 1 comment
Milestone

Comments

@christian-oreilly
Copy link
Collaborator

I just want to open the discussion on the possibility either to integrate autoreject (https://github.com/autoreject/autoreject) or build-in some kind of interoperability with that package. This may require figuring out first how we would integrate additional, optional steps, as starting to be discussed in #73.

@christian-oreilly christian-oreilly added this to the 0.05 milestone Dec 11, 2024
@scott-huberty
Copy link
Member

I think I'm in +1.

For one of my projects I actually preferred the RANSAC algorithm (which is available in autoreject; On that dataset, I was happier with the RANSAC bad channel detection than the Pylossless algorithm.. But Maybe it was just that particular dataset).

What I ended up doing was 1) Execute a Robust Average Reference and RANSAC via pyprep on my raw object 2) then running pylossless with run_with_raw 3) Tell the RejectionPolicy NOT to remove the channels flagged as Noisy (which would correspond to channels flagged by the pylossless algorithm).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants