ENH: simple HTML representation for LosslessPipeline #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- HTML repr for LosslessPipeline - string repr for flaggedCHs - flaggedICs displays the dataframe upon call - flaggedICs no longer subclasses dict, but subclasses a Dataframe directly, thus removing the .data_frame method. This is because at this point we have finished the pipeline, dashboard, and rejection policy, and have never used the flaggedICs dictionary, we only use the dataframe directly. Thus it makes more sense just to use this dataframe, and it makes the dataframe is no longer hidden from the user behind an empty dict class
Codecov Report
@@ Coverage Diff @@
## main #146 +/- ##
==========================================
+ Coverage 68.33% 69.86% +1.52%
==========================================
Files 14 16 +2
Lines 960 1012 +52
==========================================
+ Hits 656 707 +51
- Misses 304 305 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@christian-oreilly FYI in response to our discussion, the difference between |
|
self merging since this is mainly aesthetic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, this is what displays when calling a
LosslessPipelineinstance:Which can be uncollapsed:
FlaggedChsandFlaggedICsnow have nicer__repr__'s too: