Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge adjacent epoch flags into a single annotation #151

Merged
merged 3 commits into from
Nov 7, 2023
Merged

Merge adjacent epoch flags into a single annotation #151

merged 3 commits into from
Nov 7, 2023

Conversation

scott-huberty
Copy link
Member

@scott-huberty scott-huberty commented Nov 7, 2023

Closes #75

Now, instead of having several 1-second annotaitons + < 1 -second gap annotations:

Screen Shot 2023-11-07 at 12 04 34 PM

You have this 1-single annotation:

Screen Shot 2023-11-07 at 12 04 50 PM

Leading to a much better UX.

This also removes the need for the flag_gap boilerplate, which I think really was an idiosyncrasy of the MATLAB pipeline, which couldn't leverage a native annotation structure. instead of filling small (less than 1-second) "gap" annotations between two annotation of the same description, we can just merge those annotations into a single annotation.

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #151 (6d051ce) into main (a7842b2) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #151      +/-   ##
==========================================
- Coverage   78.73%   78.70%   -0.03%     
==========================================
  Files          21       21              
  Lines        1152     1141      -11     
==========================================
- Hits          907      898       -9     
+ Misses        245      243       -2     
Files Coverage Δ
pylossless/pipeline.py 74.13% <100.00%> (-0.21%) ⬇️

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@scott-huberty scott-huberty merged commit 6197698 into lina-usc:main Nov 7, 2023
5 checks passed
@scott-huberty scott-huberty deleted the merge_annots branch November 7, 2023 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Concatenate Overlapping mne.annotations
1 participant