Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate VCS‌ as a first class part of the tool #129

Open
alerque opened this issue Jun 24, 2020 · 3 comments
Open

Integrate VCS‌ as a first class part of the tool #129

alerque opened this issue Jun 24, 2020 · 3 comments

Comments

@alerque
Copy link

alerque commented Jun 24, 2020

I would like to propose adding some VCS integration on a first-class basis — not to make the font editor a full Git client of course, just to facilitate the bits where the font editor has more idea what is what than a third party generic VCS app would.

First detect whether the file being edited is also tracked in Git. If not, nothing changes. If so, add some options.

  • A "commit" option along side save that would save, stage, and commit the relevant UFO files. An extra check should probably make sure the rest of the repository status is clean before enabling this and show the feature disabled if the cache has anything in it.

  • Add a "revert" option that is basically an aggressive undo that backtracks to the last committed version. Perhaps this would function by stashing the current change, then resetting the file.

  • Add comparison functions such as a glyph editor background that shows a greyed out outline of the last commited state of a glyph. The git object store can be queried directly for the last saved object.

More is certainly possible, but if VCS was brought in as a first class part of the tooling I think the overall workflow could be radically different (and better) than any other tooling that is out there.

If this is an agreeable proposition I'm even willing to help out a bit with some implementation work. I'm not much of a graphic designer but I do have a pretty deep understanding of how Git works and I'm just getting up to speed with Rust.

@eliheuer
Copy link
Collaborator

eliheuer commented Jun 24, 2020

There is a Glyphs plugin that does something like this: https://github.com/simoncozens/GlyphsGit

It's nice to have depending on your workflow, I specifically like the idea of seeing old versions of a glyph from previous commits in the editor.

I wonder if this kind of thing would be better as a plugin, I'm not sure?

@alerque
Copy link
Author

alerque commented Jun 25, 2020

Apparently there are two similar Glyphs plugins because I actually saw this one: jenskutilek/Glyphs-SaveToGit.

@cmyr
Copy link
Member

cmyr commented Jun 25, 2020

I think this is definitely an interesting feature idea, although I'm going to hold off on thinking about it too hard until we've got some more of the fundamentals in place. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants