Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MSAA] Artifacts in cardioid with 8xMSAA and 16xMSAA #380

Closed
armansito opened this issue Oct 12, 2023 · 1 comment · Fixed by #391
Closed

[MSAA] Artifacts in cardioid with 8xMSAA and 16xMSAA #380

armansito opened this issue Oct 12, 2023 · 1 comment · Fixed by #391
Labels
bug Something isn't working

Comments

@armansito
Copy link
Collaborator

The msaa8 and msaa16 AA config's introduced in #377 render with artifacts:

From @raphlinus: "I think the artifacts you're seeing are because of only 4 bits for winding number accumulation, and that test case is a good one for slamming lots of winding number increments into a small area. I'm not 100% sure though. An obvious way to validate that would be to try an 8 bit accumulator."

@armansito armansito added the bug Something isn't working label Oct 12, 2023
@raphlinus
Copy link
Contributor

The swar8 branch has 8 bit per sample winding number accumulation in msaa8 mode, and resolves these artifacts, confirming that it was an overflow.

There is a performance degradation (not carefully measured, but enough to be significant). The plan is to detect the number of path segments in the slice: if <= 7, then use 4 bit accumulation because overflow can't happen, otherwise 8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants