Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change deprecated passlib.context.CryptoContext.encrypt to hash in password_manager.py #266

Merged
merged 1 commit into from
Nov 24, 2019

Conversation

sotlampr
Copy link
Contributor

@sotlampr sotlampr commented Jul 9, 2019

Fix for warning message:

flask_user/password_manager.py:50: DeprecationWarning: the method passlib.context.CryptContext.encrypt() is deprecated as of Passlib 1.7, and will be removed in Passlib 2.0, use CryptContext.hash() instead.

As encrypt is deprecated

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@14d30bb). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #266   +/-   ##
=========================================
  Coverage          ?   88.55%           
=========================================
  Files             ?       25           
  Lines             ?     1450           
  Branches          ?        0           
=========================================
  Hits              ?     1284           
  Misses            ?      166           
  Partials          ?        0
Impacted Files Coverage Δ
flask_user/password_manager.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14d30bb...5c64f51. Read the comment docs.

Copy link
Collaborator

@and-semakin and-semakin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sotlampr! Thank you for your contribution! Completely makes sense.

@and-semakin and-semakin merged commit 5a6583a into lingthio:master Nov 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants