Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the copyright info to be variables #280

Merged
merged 4 commits into from
Nov 30, 2019

Conversation

DonFruendo
Copy link
Contributor

Changed the flask_user_layout.html template to use variables from the user_manager_settings.py file instead of hardcoding "2014 MyCorp"

@codecov-io
Copy link

codecov-io commented Nov 11, 2019

Codecov Report

Merging #280 into master will decrease coverage by 2.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #280      +/-   ##
==========================================
- Coverage   90.62%   88.57%   -2.05%     
==========================================
  Files          25       25              
  Lines        1450     1453       +3     
==========================================
- Hits         1314     1287      -27     
- Misses        136      166      +30
Impacted Files Coverage Δ
flask_user/user_manager__settings.py 100% <100%> (ø) ⬆️
flask_user/db_adapters/mongo_db_adapter.py 35% <0%> (-60%) ⬇️
flask_user/db_manager.py 82.81% <0%> (-4.69%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86df689...e7d9754. Read the comment docs.

@DonFruendo
Copy link
Contributor Author

So I added the USER_APP_VERSION variable to the user_settings to also be able to change this.

Copy link
Collaborator

@and-semakin and-semakin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @DonFruendo!

@and-semakin and-semakin merged commit 1eec9fc into lingthio:master Nov 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants