Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MarshallingTransformationListener onError callback is not invoked #197

Closed
simekadam opened this issue Jun 24, 2022 · 4 comments
Closed

MarshallingTransformationListener onError callback is not invoked #197

simekadam opened this issue Jun 24, 2022 · 4 comments

Comments

@simekadam
Copy link
Contributor

simekadam commented Jun 24, 2022

Hi, we have recently succesfully deployed LiTr to production at Strava. So first of all kudos for your great work.
However we have also started to receive some feedback about failing processing on certain devices.
Unfortunately it bypasses our error tracking and even error handling in the UI.
I have found the issue to be the same as someone already mentioned in here

The MarshallingTransformationListeneronError callback is not invoked here because TransformationJob.release(false) hangs in my case in VideoTrackTranscoder.stop()

I can open a PR and flip the order of execution if you think it would be accepted.

@simekadam simekadam changed the title Error callback is not invoked MarshallingTransformationListener onError callback is not invoked Jun 24, 2022
@izzytwosheds
Copy link
Contributor

Thank you for using LiTr! That is so awesome to hear!

By all means, create a PR. I will be happy to review it. One of reasons making LiTr open source was to make it possible for LiTr community benefit from each other's work. Has worked out pretty well so far.

@izzytwosheds
Copy link
Contributor

You fix is in latest release 1.5.2. Thank you!

@izzytwosheds
Copy link
Contributor

Would you be ok with providing a bit more details on how you guys use LiTr. We can do that over email or LinkedIn messaging. My email is is izzat at linkedin.com.

@simekadam
Copy link
Contributor Author

Thanks! I have just bumped the version on our end.
And sure. Happy to send you over some details around how are we using it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants