Make @contextDump output consistent across different environments #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm, let's get one more pair of eyes on it. |
|
seems ok |
| //remove new line characters | ||
| .replace(/\n/mg, '') | ||
| //replace , and 0 or more spaces with ", " | ||
| .replace(/,\s?/mg, ', ') |
There was a problem hiding this comment.
\s? matches 0 or 1 whitespaces. I think you want \s*
There was a problem hiding this comment.
Good catch. That's what I meant to have there, but forgot to switch back after testing. Fixed
smfoote
added a commit
that referenced
this pull request
Dec 6, 2013
Make @contextDump output consistent across different environments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current @contextDump implementation uses value.toString() to stringify functions. That leaves JS engine responsible to decide how it wants to format the function. I'm adding few replace statements that will help make output more consistent across different browsers and JS engines.
Tested in Chrome 31, Firefox 25, Safari 6.0.5, IE10, 9, and 8