Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is, is-false, etc. as pass-throughs when no current-test? #69

Open
Zulu-Inuoe opened this issue Aug 20, 2020 · 0 comments · May be fixed by #76
Open

is, is-false, etc. as pass-throughs when no current-test? #69

Zulu-Inuoe opened this issue Aug 20, 2020 · 0 comments · May be fixed by #76

Comments

@Zulu-Inuoe
Copy link
Contributor

When editing tests, I often find myself wanting to validate things by evaluating partial expressions in Sly, for example:

(let ((v (vector 1 2 3)))
  (= 3 (length v)))

But with 5am, if I have such a thing in a test, it will be like this:

(let ((v (vector 1 2 3)))
  (is (= 3 (length v))))

and now if I try to evaluate the let, I will get
The variable IT.BESE.FIVEAM::CURRENT-TEST is unbound.

This is an open question - would it be reasonable to have the various 5am forms, such as is etc, be essentially progn's when there is no current-test? Maybe it's a problem with my workflow, but I find myself having to temporarily remove them when editing to debug & test my tests

This shouldn't have any effect on existing tests, just make the editing experience a little nicer.

Thanks!

@Zulu-Inuoe Zulu-Inuoe linked a pull request Jan 18, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant