-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add objective functions (#158) #168
Conversation
Verified Goldstein and Booth functions working and removed TODO tags. Fixed Bulkin No 6 and removed TODO tag. Implemented Cross-in-Tray, Easom, Eggholder, Himmelblau's, Holder Table, and Three Hump Camel functions. File is getting long so I sorted the functions and added a list of functions and their corresponding function name to the docstring.
Ok, this is good @jayspeidell ! |
I'll add the tests in tomorrow or Wednesday. I hadn't noticed that there were tests for the individual functions. |
Added tests for all the functions! Thanks for your patience, I know you've had to review this pull request a few times. I think I got it this time! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @jayspeidell! 🎊 Thank you a lot for your contribution! 👍 I hope you learned some things working on this PR. We always appreciate good contributors so feel free to contribute again if you want to! 💯
Hello, how do I specify if I want to either maximize or minimize my objective function? |
@Kosisochi If you have a question please open an issue and do not use closed issues for this purpose😅. By default, it minimizes the function if you put a negative sign to the cost function you find the maximum position. |
Description
Objective Function Updates: Verified Goldstein and Booth functions working and removed TODO tags. Fixed Bulkin No 6 and removed TODO tag. Implemented Cross-in-Tray, Easom, Eggholder, Himmelblau's, Holder Table, and Three Hump Camel functions. File is getting long so I sorted the functions and added a list of functions and their corresponding function name to the docstring.
Related Issue
Add more benchmark functions #158
Motivation and Context
More is better, right?
How Has This Been Tested?
I created a notebook with all the added functions and tested each function as I implemented it. All functions function in the full domain and visually match examples found online, and the minimums are what they should be.
Then I used flask8 and black. I restricted flask8 and black testing to the file that I edited.
I also ran py.test.
Screenshots (if appropriate):
Types of changes
Checklist: