Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add objective functions (#158) #168

Merged
merged 5 commits into from
Jul 18, 2018

Conversation

jayspeidell
Copy link
Contributor

@jayspeidell jayspeidell commented Jul 17, 2018

Description

Objective Function Updates: Verified Goldstein and Booth functions working and removed TODO tags. Fixed Bulkin No 6 and removed TODO tag. Implemented Cross-in-Tray, Easom, Eggholder, Himmelblau's, Holder Table, and Three Hump Camel functions. File is getting long so I sorted the functions and added a list of functions and their corresponding function name to the docstring.

Related Issue

Add more benchmark functions #158

Motivation and Context

More is better, right?

How Has This Been Tested?

I created a notebook with all the added functions and tested each function as I implemented it. All functions function in the full domain and visually match examples found online, and the minimums are what they should be.

Then I used flask8 and black. I restricted flask8 and black testing to the file that I edited.

I also ran py.test.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Verified Goldstein and Booth functions working and removed TODO tags. Fixed Bulkin No 6 and removed TODO tag. Implemented Cross-in-Tray, Easom, Eggholder, Himmelblau's, Holder Table, and Three Hump Camel functions. File is getting long so I sorted the functions and added a list of functions and their corresponding function name to the docstring.
@ljvmiranda921 ljvmiranda921 requested a review from whzup July 17, 2018 04:45
@ljvmiranda921 ljvmiranda921 added the enhancement Feature requests label Jul 17, 2018
@ljvmiranda921
Copy link
Owner

Ok, this is good @jayspeidell !
I'll now leave you to @whzup 👍

@jayspeidell
Copy link
Contributor Author

I'll add the tests in tomorrow or Wednesday. I hadn't noticed that there were tests for the individual functions.

@ljvmiranda921 ljvmiranda921 added v0.3.0 unit tests Test-related changes labels Jul 17, 2018
@jayspeidell
Copy link
Contributor Author

Added tests for all the functions! Thanks for your patience, I know you've had to review this pull request a few times. I think I got it this time!

Copy link
Collaborator

@whzup whzup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @jayspeidell! 🎊 Thank you a lot for your contribution! 👍 I hope you learned some things working on this PR. We always appreciate good contributors so feel free to contribute again if you want to! 💯

@whzup whzup merged commit 4d0e69a into ljvmiranda921:development Jul 18, 2018
@ljvmiranda921 ljvmiranda921 mentioned this pull request Jul 31, 2018
12 tasks
@Kosisochi
Copy link

Hello, how do I specify if I want to either maximize or minimize my objective function?

@whzup
Copy link
Collaborator

whzup commented Sep 16, 2020

@Kosisochi If you have a question please open an issue and do not use closed issues for this purpose😅. By default, it minimizes the function if you put a negative sign to the cost function you find the maximum position.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests unit tests Test-related changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants