Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a home button in Grid Paint activity #546

Closed
s-mag opened this issue Jan 1, 2020 · 9 comments
Closed

Add a home button in Grid Paint activity #546

s-mag opened this issue Jan 1, 2020 · 9 comments
Labels
enhancement to be release Fixed, to be release
Milestone

Comments

@s-mag
Copy link
Contributor

s-mag commented Jan 1, 2020

A home button should be added on toolbar so that a palette or drawing board can be changed instead of the small round button in the corner...

I guess this should avoid confusion and will improve UI.

Grid Paint

gp

Currently tested in Firefox...
What do you think @llaske @FreddieN ?

@llaske
Copy link
Owner

llaske commented Jan 1, 2020

I'm agree that the meaning of the small green circle is not clear.
BTW I'm not sure adding a button in the toolbar is a good idea. May be we can just transform the circle in a more significant icon. Do you have any suggestion?

@s-mag
Copy link
Contributor Author

s-mag commented Jan 1, 2020

I'm agree that the meaning of the small green circle is not clear.
BTW I'm not sure adding a button in the toolbar is a good idea. May be we can just transform the circle in a more significant icon. Do you have any suggestion?

We can just change the icon to a home or kinda of a back button....

@llaske
Copy link
Owner

llaske commented Jan 1, 2020

Let's try a back button

@s-mag
Copy link
Contributor Author

s-mag commented Jan 1, 2020

Let's try a back button

So should I choose a icon myself under free to use license and make a PR

@llaske
Copy link
Owner

llaske commented Jan 1, 2020

Try to the use the < icon (see in Calligra activity on dev branch)

@s-mag
Copy link
Contributor Author

s-mag commented Jan 1, 2020

Try to the use the < icon (see in Calligra activity on dev branch)

I guess adding a button in toolbar would be better as the round button is drawn here.
What are your thoughts on this..
Or we can add the back button in upper left corner of the board...
It will be easily accessible.

@llaske
Copy link
Owner

llaske commented Jan 2, 2020

Let's try to put the back button in upper left corner

@s-mag
Copy link
Contributor Author

s-mag commented Jan 2, 2020

Let's try to put the back button in upper left corner

Moreover there is a issue that if we click around the button it works....
ezgif com-video-to-gif

So it would be nice to remove it.

@llaske
Copy link
Owner

llaske commented Jan 19, 2020

Fixed in #565

@llaske llaske added the to be release Fixed, to be release label Jan 19, 2020
@llaske llaske added this to the v1.3 milestone Mar 11, 2020
@llaske llaske closed this as completed Mar 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement to be release Fixed, to be release
Projects
None yet
Development

No branches or pull requests

2 participants