Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Private button in presence palette shares the activity #811

Closed
dhruvmisra opened this issue May 30, 2020 · 3 comments
Closed

Private button in presence palette shares the activity #811

dhruvmisra opened this issue May 30, 2020 · 3 comments
Labels
bug to be release Fixed, to be release
Milestone
v1.4

Comments

@dhruvmisra
Copy link
Contributor

dhruvmisra commented May 30, 2020 •
edited
Loading

See here:

presence1
presence2

It happens in all other activities using the Presence palette. The styling of the palette also becomes erratic as connected user overflows and private/share buttons aren't disabled.

The problem might be linked to the file lib/sugar-web/presence.js which was updated recently to display connected users.
@llaske llaske added the bug label May 30, 2020
@llaske
Copy link
Owner

llaske commented May 30, 2020

Should be fixed by #813
Could you check on your side?

@llaske llaske mentioned this issue May 30, 2020
Closed
@dhruvmisra
Copy link
Contributor Author

Yes, it works well on my side too.

@llaske
Copy link
Owner

llaske commented Jun 2, 2020

Fixed in 95e9cd2

@llaske llaske added the to be release Fixed, to be release label Jun 2, 2020
@llaske llaske added this to the v1.4 milestone Sep 19, 2020
@llaske llaske closed this as completed Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug to be release Fixed, to be release
Projects
None yet
Milestone
v1.4
Development

No branches or pull requests
2 participants
@llaske @dhruvmisra