Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong values for inverse trigonometric function in Calculate Activity #895

Closed
saurabhhere opened this issue Oct 31, 2020 · 6 comments
Closed
Labels
bug to be release Fixed, to be release
Milestone

Comments

@saurabhhere
Copy link
Contributor

Below mentioned bugs are achieved from Sugarizer web (http://try.sugarizer.org/)

Getting wrong value of inverse trigonometric function when angle type is 'degree' :

For asin(0.5) expected value is 60 degree but we are getting 0.000152
Also the range for x in asin(x) is from -1 to 1 but calculator is showing value for x =2 also:

Screenshot from 2020-11-01 00-45-35

Same problems are with acos(x) & atan(x) when angle type is 'degree'.

[Suggestion] In case of tan, calculator is showing finite values for both tan(90°) & tan(π/2), we can either write infinite or not defined instead of showing a finite number.

Screenshot from 2020-11-01 00-55-29

@llaske llaske added the bug label Nov 7, 2020
@llaske
Copy link
Owner

llaske commented Nov 7, 2020

Good shot. Thanks.
And it look like it's only in degree mode.

image

@mikklfr do you think it could be related to the automatic degree to radian conversion here?

@Parthkhandelwal0
Copy link

hey @llaske! is anyone working on this issue? i would like to contribute should i go ahead?

@llaske
Copy link
Owner

llaske commented Dec 11, 2020

Hi @Parthkhandelwal0, you're welcome to work on it.

@saurabhhere
Copy link
Contributor Author

Hi @Parthkhandelwal0, are you working on this issue?

@amitchakraborti9
Copy link
Contributor

Hi @llaske,
I just submitted a pull request which fixes the issue without implementing the suggestion.

@llaske
Copy link
Owner

llaske commented Dec 20, 2020

Fixed by #908

@llaske llaske added the to be release Fixed, to be release label Dec 20, 2020
@llaske llaske added this to the v1.5 milestone Apr 26, 2021
@llaske llaske closed this as completed Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug to be release Fixed, to be release
Projects
None yet
Development

No branches or pull requests

4 participants