Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dollar street activity not loading. #985

Closed
AnandChourasia007 opened this issue Feb 28, 2022 · 12 comments
Closed

Dollar street activity not loading. #985

AnandChourasia007 opened this issue Feb 28, 2022 · 12 comments
Labels
bug to be release Fixed, to be release
Milestone

Comments

@AnandChourasia007
Copy link
Contributor

AnandChourasia007 commented Feb 28, 2022

On clicking on the dollar street activity icon, a new page begins loading. But the loading never completes and an error is logged in the console, 'HTTP error: status code 404, net::ERR_HTTP_RESPONSE_CODE_FAILURE'.

Dollar street activity not loading

However, the buttons 'filter by region' and 'see families' work perfectly fine.

Issue-clarification.mp4

Also, the slider boundary values in the 'filter by income' button are set to NaN.
Slider limits issue

@codebloded
Copy link
Contributor

@AnandChourasia007 hey, are you working on this issue?

@llaske
Copy link
Owner

llaske commented Feb 28, 2022

@AnandChourasia007 Hmmm, you're right. I guess that something has changed in the API.

@llaske llaske added the bug label Feb 28, 2022
@AnandChourasia007
Copy link
Contributor Author

@AnandChourasia007 hey, are you working on this issue?

Umm, I cannot work on this for the next week at least(due to my mid semester exams). 😪
So feel free to try and fix it.

@codebloded
Copy link
Contributor

@AnandChourasia007 Hmmm, you're right. I guess that something has changed in the API.

Yes @llaske when i backtrack this thing , i found api isn't working properly for this thing, there is an function inside apiref, which return NaN instead of number

@llaske
Copy link
Owner

llaske commented Mar 3, 2022

@codebloded something similar happens last year (see here).
To fix it, the idea is to debug how the original website works and try to do the same.

@AnandChourasia007
Copy link
Contributor Author

AnandChourasia007 commented Mar 4, 2022

@AnandChourasia007 Hmmm, you're right. I guess that something has changed in the API.

Yes @llaske when i backtrack this thing , i found api isn't working properly for this thing, there is an function inside apiref, which return NaN instead of number

The function returns NaN because the api used in Sugariser for this activity doesn't exist anymore. The new API will have to be integrated now I think.
dollarstreet email response
Also, I couldn't find the API on their latest website.

@llaske
Copy link
Owner

llaske commented Mar 4, 2022

@AnandChourasia007 There is no documentation about the API because it's not directly intended to be shared. To create the DollarStreet activity we've just done reverse engineering - with the authorization of Gapminder - on the current website to understand how it works.
So to fix the issue, the same work should be done/adapted.

@AnandChourasia007
Copy link
Contributor Author

Oh I see

@dhwaj1902
Copy link
Contributor

Hi, I was debugging the dollar street activity I found that this API https://ds-dev.dollarstreet.org/dollar-street/v1/ is no longer exists, and this API is used to get street-settings, languages, region-filter and things-filter. The region and things filter can be done with this https://api.dollarstreet.org/v1/ API, while for settings and language we need to hard code the things.

@llaske
Copy link
Owner

llaske commented Mar 16, 2022

Yes you're right the API https://ds-dev.dollarstreet.org/dollar-street/v1/ no longer work.

BTW I don't see any mention of https://api.dollarstreet.org/v1/ API call. It look like values for street-settings, languages, region-filter and things-filter are now directly included in the HTML page:

image

May be we could extract them manually (at first) to fix the issue?

@llaske
Copy link
Owner

llaske commented Mar 27, 2022

Help is still wanted here.

@llaske
Copy link
Owner

llaske commented Apr 16, 2022

Fix in 2f5026d

@llaske llaske added the to be release Fixed, to be release label Apr 16, 2022
@llaske llaske added this to the v1.7 milestone Mar 28, 2023
@llaske llaske closed this as completed Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug to be release Fixed, to be release
Projects
None yet
Development

No branches or pull requests

4 participants