Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR for llvm/llvm-project#70004 #764

Merged
merged 1 commit into from
Nov 13, 2023
Merged

PR for llvm/llvm-project#70004 #764

merged 1 commit into from
Nov 13, 2023

Conversation

llvmbot
Copy link
Member

@llvmbot llvmbot commented Oct 31, 2023

@alexey-bataev @nikic
[SLP]Fix PR70004: Do not change insert point for reduction gather nodes.
a0b373c 
No need to change the insert point for reduction gather node, we can use
the ReductionRoot as insert point instead to avoid possible crashes.

(cherry picked from commit d79051f894129428ec36dedc6bbfdfdcc1bd0c17)
@llvmbot llvmbot mentioned this pull request Oct 31, 2023
Closed
@tru
Copy link
Contributor

tru commented Nov 13, 2023

@nikic ok to backport?

@nikic
Copy link
Contributor

nikic commented Nov 13, 2023

Probably @alexey-bataev should review this for backport.

@tru tru merged commit 529aa6e into release/17.x Nov 13, 2023
15 checks passed
@tru tru deleted the nikic-slp-backport branch November 13, 2023 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexey-bataev alexey-bataev alexey-bataev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SLPVectorizer produces use-before-def after 03b118c
4 participants
@llvmbot @tru @nikic @alexey-bataev