PR for llvm/llvm-project#69717 #774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rjmccall @spavloff @AaronBallman is this fine to backport to 17.x? (I think the answer is yes, but anyway :) |
llvmbot
force-pushed
the
llvm-issue69717
branch
from
bd01699 to
5e7dba9
Compare
…0646) When instantiation function, a call to Sema::resetFPOption was used to set the FP options associated with AST node. However this function also cleared FP pragma stack, and it is incorrect. Template instantiation takes place on AST representation and semantic information like the FP pragma stack should not affect it. This was a reason for miscompilation in some cases. To make the Sema interface more consistent, now `resetFPOptions` does not clear FP pragma stack anymore. It is cleared in `FpPragmaStackSaveRAII`, which is used in parsing only. This change must fix llvm/llvm-project#69717 (Problems with float_control pragma stack in Clang 17.x). (cherry picked from commit f6f625f4c6c3cbeb8cf6b889cdafc848dd4cb117)
The test Sema/PR69717.cpp fails on platforms that do not support pragma float_control. So run this test on x86 only. (cherry picked from commit 93ae26331592f41bf2b1d10b048743d80c468385)
Test still fail on ARM machine (no float_control support) (cherry picked from commit 5fdb70be7b0a1340a7ebdeb94ab073e466fc4aa6)
llvmbot
force-pushed
the
llvm-issue69717
branch
from
5e7dba9 to
0326c8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves llvm/llvm-project#69717