Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fmtlib compilation fails (consteval) on clang main branch #113517

Closed
kamrann opened this issue Oct 24, 2024 · 6 comments
Closed

fmtlib compilation fails (consteval) on clang main branch #113517

kamrann opened this issue Oct 24, 2024 · 6 comments
Labels
clang:frontend Language frontend issues, e.g. anything involving "Sema" consteval C++20 consteval invalid Resolved as invalid, i.e. not a bug

Comments

@kamrann
Copy link

kamrann commented Oct 24, 2024

https://godbolt.org/z/bf5MeK3TW

It's not entirely clear since this issue does not show up if using fmtlib master branch, but only on the latest 11.0.2 release. However, since 11.0.2 builds fine with MSVC, GCC and Clang 19, it suggests a probable regression.

@github-actions github-actions bot added the clang Clang issues not falling into any other category label Oct 24, 2024
@EugeneZelenko EugeneZelenko added clang:frontend Language frontend issues, e.g. anything involving "Sema" consteval C++20 consteval and removed clang Clang issues not falling into any other category labels Oct 24, 2024
@llvmbot
Copy link
Member

llvmbot commented Oct 24, 2024

@llvm/issue-subscribers-clang-frontend

Author: Cameron Angus (kamrann)

https://godbolt.org/z/bf5MeK3TW

It's not entirely clear since this issue does not show up if using fmtlib master branch, but only on the latest 11.0.2 release. However, since 11.0.2 builds fine with MSVC, GCC and Clang 19, it suggests a probable regression.

@tbaederr
Copy link
Contributor

The error doesn't ring a bell here. Can you provide the preprocessed sources for that file?

The only thing that comes to mind is the string literal change, wasn't there a problem in fmtlib that got fixed in their master branch, @zygoloid?

@kamrann
Copy link
Author

kamrann commented Oct 24, 2024

Can you provide the preprocessed sources for that file?

For fmt? I just added -E to the CE invocation and pasted the output back into the input. If you meant something else, let me know.

@zygoloid
Copy link
Collaborator

This was a bug in fmtlib that's fixed in their trunk, combined with all compilers previously being overly permissive in repeated constant evaluation of string literals.

@kamrann
Copy link
Author

kamrann commented Oct 26, 2024

Understood, sorry for the false report then. I searched on fmtlib initially but missed that issue somehow.

@kamrann kamrann closed this as completed Oct 26, 2024
@EugeneZelenko EugeneZelenko added the invalid Resolved as invalid, i.e. not a bug label Oct 26, 2024
@EugeneZelenko EugeneZelenko closed this as not planned Won't fix, can't repro, duplicate, stale Oct 26, 2024
@zygoloid
Copy link
Collaborator

No worries, thanks for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang:frontend Language frontend issues, e.g. anything involving "Sema" consteval C++20 consteval invalid Resolved as invalid, i.e. not a bug
Projects
None yet
Development

No branches or pull requests

5 participants