-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
💄 style: support to reset fetched models #4260
Conversation
@vual is attempting to deploy a commit to the LobeChat Community Team on Vercel. A member of the Team first needs to authorize it. |
👍 @vual Thank you for raising your pull request and contributing to our Community |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4260 +/- ##
==========================================
- Coverage 92.31% 92.30% -0.02%
==========================================
Files 528 528
Lines 36998 37013 +15
Branches 2363 2518 +155
==========================================
+ Hits 34155 34164 +9
- Misses 2843 2849 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
建议放在我画圈的位置,用 ActionIcon 组件 (默认不展示文本只放图标,hover 才显示 title)。放你现在那个位置很容易出现多点一次重置模型的情况,即 CLS 会有问题。详见:https://web.dev/articles/cls?hl=zh-cn |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
功能没问题了,把这个细节实现再修一下~
另外可以跑下 npm run i18n 自动生成 locale
src/app/(main)/settings/llm/components/ProviderModelList/ModelFetcher.tsx
Outdated
Show resolved
Hide resolved
@vual 配到 .env 里 |
@vual allocated to .env |
可以了。 |
That's it. |
rebase 下 main |
rebase under main |
可以了。 |
That's it. |
有问题哈,locale 这边不应该有回车的,你需要跑一下 git commit 前的 lint 自动格式化掉。 |
There is a problem. There should not be a carriage return in the locale. You need to run lint before git commit to automatically format it. |
重新pnpm run i18n了,应该可以了。 |
Re-pnpm run i18n, it should be OK. |
rebase 下main? 另外 locale 的更新不应该每个都加回车的,你是不是提交前没跑下 lint 和 format? 功能代码上没问题了, locale 的部分处理下 |
Rebase under main? In addition, every locale update should not include a carriage return. Did you not run lint and format before submitting? There is no problem with the function code |
很奇怪,我并没有加回车,我只是重跑了npm run i18n |
It's strange, I didn't add the carriage return, I just reran npm run i18n |
重跑以后正常提交会做一次格式化,会自动把回车去掉的,你是不是跳过 commit 时候的hook了? |
After re-running, normal submission will be formatted and the carriage return will be automatically removed. Did you skip the hook during commit? |
有可能,我重新弄下 |
It's possible, I'll do it again |
弄好了,你再检查看看 |
It's done, check again |
171293a
to
7eb7063
Compare
❤️ Great PR @vual ❤️ The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world. |
### [Version 1.32.9](v1.32.8...v1.32.9) <sup>Released on **2024-11-24**</sup> #### 💄 Styles - **misc**: Support to reset fetched models. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### Styles * **misc**: Support to reset fetched models, closes [#4260](#4260) ([22480a9](22480a9)) </details> <div align="right"> [![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top) </div>
🎉 This PR is included in version 1.32.9 🎉 The release is available on: Your semantic-release bot 📦🚀 |
### [Version 1.74.5](v1.74.4...v1.74.5) <sup>Released on **2024-11-24**</sup> #### 🐛 Bug Fixes - **misc**: Fix `XAI_PROXY_URL` env missing. #### 💄 Styles - **misc**: Support to reset fetched models. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### What's fixed * **misc**: Fix `XAI_PROXY_URL` env missing, closes [lobehub#4747](https://github.com/bentwnghk/lobe-chat/issues/4747) ([7c9e88e](7c9e88e)) #### Styles * **misc**: Support to reset fetched models, closes [lobehub#4260](https://github.com/bentwnghk/lobe-chat/issues/4260) ([22480a9](22480a9)) </details> <div align="right"> [![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top) </div>
💻 变更类型 | Change Type
🔀 变更说明 | Description of Change
增加【清除获取的模型】的功能,主要是用于在获取模型列表后,不想要了,需要恢复系统自带的模型。
📝 补充信息 | Additional Information