Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ refactor: refactor getLlmOptionsFromPayload from AgentRuntime #4790

Merged
merged 8 commits into from
Nov 26, 2024

Conversation

hezhijie0327
Copy link
Contributor

@hezhijie0327 hezhijie0327 commented Nov 25, 2024

💻 变更类型 | Change Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 👷 build
  • ⚡️ perf
  • 📝 docs
  • 🔨 chore

🔀 变更说明 | Description of Change

  1. 合并大部分通用 Provider,默认从 provider 转换为大写后拼接,即 ${upperProvider}_API_KEY${upperProvider}_PROXY_URL

📝 补充信息 | Additional Information

Copy link

vercel bot commented Nov 25, 2024

@hezhijie0327 is attempting to deploy a commit to the LobeChat Community Team on Vercel.

A member of the Team first needs to authorize it.

@lobehubbot
Copy link
Member

👍 @hezhijie0327

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
非常感谢您提出拉取请求并为我们的社区做出贡献,请确保您已经遵循了我们的贡献指南,我们会尽快审查它。
如果您遇到任何问题,请随时与我们联系。

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 76.19048% with 5 lines in your changes missing coverage. Please review.

Project coverage is 92.47%. Comparing base (bef89a7) to head (2f16dee).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/server/modules/AgentRuntime/index.ts 76.19% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4790      +/-   ##
==========================================
+ Coverage   92.29%   92.47%   +0.17%     
==========================================
  Files         530      530              
  Lines       37109    36911     -198     
  Branches     3529     2469    -1060     
==========================================
- Hits        34251    34134     -117     
+ Misses       2858     2777      -81     
Flag Coverage Δ
app 92.47% <76.19%> (+0.17%) ⬆️
server 96.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hezhijie0327 hezhijie0327 marked this pull request as ready for review November 25, 2024 13:51
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Nov 25, 2024
Copy link

vercel bot commented Nov 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lobe-chat-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 26, 2024 2:26am

@arvinxx arvinxx merged commit e8948e6 into lobehub:main Nov 26, 2024
7 of 8 checks passed
@lobehubbot
Copy link
Member

❤️ Great PR @hezhijie0327 ❤️

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.
项目的成长离不开用户反馈和贡献,感谢您的贡献! 如果您对 LobeHub 开发者社区感兴趣,请加入我们的 discord,然后私信 @arvinxx@canisminor1990。他们会邀请您加入我们的私密开发者频道。我们将会讨论关于 Lobe Chat 的开发,分享和讨论全球范围内的 AI 消息。

@hezhijie0327 hezhijie0327 deleted the agentRuntime branch November 26, 2024 03:40
github-actions bot pushed a commit that referenced this pull request Nov 26, 2024
### [Version&nbsp;1.33.4](v1.33.3...v1.33.4)
<sup>Released on **2024-11-26**</sup>

#### ♻ Code Refactoring

- **misc**: Refactor `getLlmOptionsFromPayload` from AgentRuntime.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### Code refactoring

* **misc**: Refactor `getLlmOptionsFromPayload` from AgentRuntime, closes [#4790](#4790) ([e8948e6](e8948e6))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
@lobehubbot
Copy link
Member

🎉 This PR is included in version 1.33.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit to bentwnghk/lobe-chat that referenced this pull request Nov 26, 2024
### [Version&nbsp;1.75.3](v1.75.2...v1.75.3)
<sup>Released on **2024-11-26**</sup>

#### ♻ Code Refactoring

- **misc**: Refactor `getLlmOptionsFromPayload` from AgentRuntime.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### Code refactoring

* **misc**: Refactor `getLlmOptionsFromPayload` from AgentRuntime, closes [lobehub#4790](https://github.com/bentwnghk/lobe-chat/issues/4790) ([e8948e6](e8948e6))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants