Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update data_type comments in redis.rb #70

Merged
merged 1 commit into from
Jan 16, 2019

Conversation

candlerb
Copy link
Contributor

  • Change redis_type to data_type in the comments for config :data_type
  • Backslash-escaping of underscore is not required for Markdown text quoted in backticks

Thanks for contributing to Logstash! If you haven't already signed our CLA, here's a handy link: https://www.elastic.co/contributor-agreement/

* Change `redis_type` to `data_type` in the comments for `config :data_type`
* Backslash-escaping of underscore is not required for Markdown text quoted in backticks
Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@karenzone karenzone merged commit 3f1a806 into logstash-plugins:master Jan 16, 2019
@karenzone
Copy link
Contributor

@candlerb Thanks for your contribution and for helping us improve our documentation.

@candlerb candlerb mentioned this pull request Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants