-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Storage fix and other features #44
Conversation
Signed-off-by: Stephen L. <[email protected]>
Signed-off-by: Stephen L. <[email protected]>
Signed-off-by: Stephen L. <[email protected]>
… load SimpleStorage Signed-off-by: Stephen L. <[email protected]>
…tandardize extension to 1list.json (for compatibility and clarity that it is a DocumentFile, not a MediaStore) + add button to copy all lists to new storage location + bump version 1.3.2-DEV Signed-off-by: Stephen L. <[email protected]>
Signed-off-by: Stephen L. <[email protected]>
Signed-off-by: Stephen L. <[email protected]>
Signed-off-by: Stephen L. <[email protected]>
Signed-off-by: Stephen L. <[email protected]>
…lots of comments to ease future maintenance (literate programming) Signed-off-by: Stephen L. <[email protected]>
…top (fixes lolo-io#32) Signed-off-by: Stephen L. <[email protected]>
…reference Signed-off-by: Stephen L. <[email protected]>
Signed-off-by: Stephen L. <[email protected]>
Signed-off-by: Stephen L. <[email protected]>
1aff93c
to
cd687b6
Compare
…antaneously in EditItemDialog (no more slowdowns) by reusing OneListFragment's allLists Signed-off-by: Stephen L. <[email protected]>
…s current selectedList Signed-off-by: Stephen L. <[email protected]>
Signed-off-by: Stephen L. <[email protected]>
66126fb
to
e228037
Compare
Signed-off-by: Stephen L. <[email protected]>
@lolo-io did you have time to have a look? Please let me know if you need me to change something :-) |
Also I've been using the debug apk for a week now on a daily basis, everything seems to work very fine! |
…opying lists to defaultPath Signed-off-by: Stephen L. <[email protected]>
… tasks, instead of after done tasks + fix draggable range and avoid crashes with doneItemsToBottom option Signed-off-by: Stephen L. <[email protected]>
…backs (no change in UX, it's just for future code maintenance) Signed-off-by: Stephen L. <[email protected]>
…ge, should just delete list.path Signed-off-by: Stephen L. <[email protected]>
…n UI in EditListDialog until app is closed and reopened Signed-off-by: Stephen L. <[email protected]>
Signed-off-by: Stephen L. <[email protected]>
Signed-off-by: Stephen L. <[email protected]>
@lolo-io just to let you know that I did a last pass of polishing on this PR to clean up all remaining issues such as implementing confirmation dialogs and some edge case errors, except portuguese translation, so this PR can be merged without additional work. |
Signed-off-by: Stephen L. <[email protected]>
Four months later I am still using this build in production, combined with SyncThing to make a backup to a computer, and it works flawlessly. It is very stable, it can be merged whenever you want @lolo-io . |
@lolo-io If you give me access to this GitHub repository and the Android store for this app, I can take care of maintaining it. I would like to avoid making a fork, but I think it's a shame that this app is abandoned now despite its huge potential. If you cannot take care of it anymore, please let someone else maintain it. |
Hi @lrq3000. A am back on this project after a long time of absence. I also wasn't happy with the codebase, so I refactored all of it to make it more aligned with nowadays coding standards. There is still work to do on that side but I'm on it. The consequence is that all previous PRs are totally out of date now. I want to thank you for your PR even if I didn't merge it. It was very useful, I looked into it during my refacto. I used SimpleStorage as you advised me. Anyway, thanks for the support. Sorry for having been away so long, |
No problem, thank you @lolo-io for your huge work refactoring your great app and I'm glad if my code could help at least with some parts of the implemeetation, SimpleStorage is an awesome library that makes our lives easier as Android devs 😄 |
This PR is based on the
develop
branch and it implements the following changes:.1list.json
instead of.1list
as before (EDIT: in fact it's possible to force a custom file extension by not specifying amimeType
inmakeFile()
inPersistenceHelper.kt
, but then it may be risky in the future, maybe Android may confuse this with aMediaStore
file and restrict permission if it is unsure it's aDocumentFile
, so I would rather keep.1list.json
just to be sure, and also 3rd-party reading apps can more easily open these files). Big thanks to @anggrayudi for his help with making this possible despite Google's insanity! (See issues here and here). Fixes Error while getting your list from content #41, fixes Default storage folder is ignored #26 and fixes Export/Import lists #38.For those who are impatient, a debug APK is available here: https://github.com/lrq3000/OneList/releases/tag/storage-fix-and-more-features-bugfix5
Important note: this PR increases the minimum API from 16 to 19 to support the minimum libraries required for SimpleStorage to work, so by merging this we drop support for Android versions older than 19 (KITKAT).
@lolo-io This PR is fully functional, and if you don't like the additional features, you can just cherry-pick whichever commits you want, I rebased to separate them cleanly.
However there are a few minor things that could be improved:
As you can see, these are very minor issues, it's just that I am not experienced enough with making dialogs. We only need very simple dialogs to make these two options perfectly fine. This can be done at a later point in time.This is now done.Also note that I left
Log.d
calls on purpose, as they are anyway muted and skipped in the compiled app, but are very helpful if we ever need to debug storage issues again (especially if users need to debug! You can ask for a dump and it will tell you right away where there is an issue and if permissions were correctly granted).