-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relation refactoring: Split Repository interface into different interfaces #1356
Comments
from @raymondfeng follow-up discussion: We need more time to discuss. Revisit it next time. |
@strongloop/sq-lb-apex @hacksparrow @raymondfeng @bajtos Any updates on this story? |
@jannyHou Sorry, I need to work with @raymondfeng to update the acceptance criteria. I'll have it ready for our next estimation meeting. |
Here are some candidates I see:
|
This issue has been marked stale because it has not seen activity within six months. If you believe this to be in error, please contact one of the code owners, listed in the |
This issue has been closed due to continued inactivity. Thank you for your understanding. If you believe this to be in error, please contact one of the code owners, listed in the |
Description / Steps to reproduce / Feature proposal
See #1194 (comment) for background. This tasks aims to break up the
Repository
interface into different interfaces based on the persistence function type and refactor the repository interfaces which extend from it to use those interfaces via a Mixin.Acceptance Criteria
Repository
interface into different interfaces based on the persistence function type i.e.LookupRepository
interface to have all the Retrieval methods,,WriteRepository
(I'm sure there is a better name), would have the create methodsMutationRepository
might have the update and related methods (this might fall under the previous one),and. A good list from @raymondfeng:DestroyRepository
for deletesExplore the use of a Mixin for a smart way of sharing the implementation bits from the different repositories (for e.g. how can
HasManyEntityCrudRepository
inherit the needed CRUD methods from the interfaces mentioned above?).tests / docs
The text was updated successfully, but these errors were encountered: