Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Component page under Key Concepts #2020

Closed
3 tasks
dhmlau opened this issue Nov 13, 2018 · 8 comments
Closed
3 tasks

Add Component page under Key Concepts #2020

dhmlau opened this issue Nov 13, 2018 · 8 comments
Assignees
Labels

Comments

@dhmlau
Copy link
Member

dhmlau commented Nov 13, 2018

Description / Steps to reproduce / Feature proposal

In https://loopback.io/doc/en/lb4/Crafting-LoopBack-4.html#rebuilding-loopback-experience-on-top-of-the-new-core, the link for Component is broken.

Talked to @raymondfeng , we should have a page for Component under concepts.

Related to #1908

Acceptance Criteria

  • Create a Component page under Key concepts. Describe the functionality and interface of a Component class on it.
  • Refactor the Using components page by moving relevant content to Component page.
  • Link the Component page from Concepts page.
@bajtos
Copy link
Member

bajtos commented Feb 8, 2019

As a short-term solution to fix the broken link, I am proposing to point readers to https://loopback.io/doc/en/lb4/Extending-LoopBack-4.html for now as part of this story, and create a new story to write Component page under Concepts.

@dhmlau
Copy link
Member Author

dhmlau commented Feb 10, 2019

Created PR #2361 to fix the broken link, and updated the Acceptance Criteria.

@dhmlau
Copy link
Member Author

dhmlau commented Feb 10, 2019

@raymondfeng , what content do you have in mind for that Component page? given that we have https://loopback.io/doc/en/lb4/Using-components.html. Thanks.

@dhmlau
Copy link
Member Author

dhmlau commented Feb 11, 2019

Fixed the broken link through PR #2361. Moving this out of TOB.

@dhmlau dhmlau added 2019Q2 and removed TOB labels Feb 11, 2019
@dhmlau dhmlau changed the title Component link in Crafting LB4 page is broken Add Component page under Key Concepts Feb 28, 2019
@dhmlau
Copy link
Member Author

dhmlau commented Apr 10, 2019

I forgot that we need to estimate this task first.
@hacksparrow, could you please edit the acceptance criteria? Thanks!

@emonddr
Copy link
Contributor

emonddr commented Apr 11, 2019

@dhmlau

In https://loopback.io/doc/en/lb4/Crafting-LoopBack-4.html#rebuilding-loopback-experience-on-top-of-the-new-core, the link for Component is broken.

I don't see the word Component on the url you mentioned. Do you mean it is missing somewhere on the left side bar?

@dhmlau
Copy link
Member Author

dhmlau commented Apr 12, 2019

Sorry.. I think I was referring to the section above. Should be here: https://loopback.io/doc/en/lb4/Crafting-LoopBack-4.html#deep-dive-into-loopback-4-extensibility. But I fixed the broken link to point to the using-component.md.

@dhmlau dhmlau added p1 and removed needs grooming labels Apr 16, 2019
@dhmlau dhmlau added this to the May 2019 milestone milestone May 6, 2019
@dhmlau
Copy link
Member Author

dhmlau commented May 6, 2019

Closing as resolved because PR #2702 has merged.

@dhmlau dhmlau closed this as completed May 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants