-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review LoopBack's Long Term Support Policy #4826
Comments
@achrinza, just wanna clarify on the Module LTS policy. An example might be easier to illustrate that because it took me a while to understand that. :)
As a result, the individual LoopBack modules generally meet (or exceed) the Module LTS policy requirements. Having said that, if you find this is not the case, please do let us know! |
Thanks @dhmlau, for the example. From my understanding, your example is definitely correct, but I believe it's missing one point. I'd like to take an example from this monorepo as it's what's of concern (
It's understandable to drop support for an older version of Node.js to utilise new features, however the Typescript/Babel compiler reduces the amount of times this is necessary. For example, this commit dropped support for Node.js 8 as it's EOL. However, there was no changes to the Hence, there shouldn't have been a need to drop support for Node.js 8 yet - not until a Typescript release breaks compatibility with that version of Node.js. or we need to utilise a new Typescript feature that requires us to increase the |
There's also the concern that we're adopting Module LTS for the LoopBack framework as a whole, and not on the individual packages which may adoption of individual LoopBack packages (e.g. |
Suggestion
Loosely related: #4398
This issue consists of 2 points, both related the Module LTS polcy:
Adopt Module LTS on the individual packages
LoopBack 4 claims to adopt the CloudNative Module LTS Policy. This only applies to the project as a whole, and semver major bumps within the individual packages in the monorepo do not follow the Module LTS policy.
This may be misleading as users may expect the individual packages to adopt the policy, and not the "blanket" project version 4. This means that we may be bringing unexpected breaking changes to our users. Especially for those who adopt the individual packages and not the LoopBack framework as a whole.
Do not drop Node.js versions after EOL
Current practice is to drop a Node.js version when it EOLs. However, the Module LTS Policy says to only drop when a backwards-incompatible change is necessary to be compatible with the latest version of Node.js:
Acceptance criteria
TBD - will be filled by the team.
The text was updated successfully, but these errors were encountered: