Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

关于setMaxMillisecond的Bug #47

Closed
seeeeal opened this issue Jan 10, 2022 · 7 comments
Closed

关于setMaxMillisecond的Bug #47

seeeeal opened this issue Jan 10, 2022 · 7 comments

Comments

@seeeeal
Copy link

seeeeal commented Jan 10, 2022

设备:Pixel4
系统版本:Android12

场景:Demo中的CardDatePickerDialog
Max Value: 2022-01-06 15:47:47
Min Value: 1990-09-10 15:48:01
Def Value: 2000-12-22 15:48:10

点击Show Dialog

默认时间将显示在2000年1月1日15时0分10秒


经过观察发现只要Def value的Month或者Day > Max Value的Month或者Day,显示便会出错

@seeeeal
Copy link
Author

seeeeal commented Jan 10, 2022

Screenshot_20220110-160407
Screenshot_20220110-160410

@loper7 loper7 closed this as completed in 618808a Jan 17, 2022
@loper7
Copy link
Owner

loper7 commented Jan 17, 2022

设备:Pixel4 系统版本:Android12

场景:Demo中的CardDatePickerDialog Max Value: 2022-01-06 15:47:47 Min Value: 1990-09-10 15:48:01 Def Value: 2000-12-22 15:48:10

点击Show Dialog

默认时间将显示在2000年1月1日15时0分10秒

经过观察发现只要Def value的Month或者Day > Max Value的Month或者Day,显示便会出错

0.5.3 已处理

@HeJingWei
Copy link

还是有一点问题,传入12月的默认时间时,会选中到1月

@HeJingWei
Copy link

貌似是因为mMonthSpinner设置max和min的时候 月份没有加1 传入的月份是12时 12大于了11造成的

@loper7
Copy link
Owner

loper7 commented Jan 25, 2022

貌似是因为mMonthSpinner设置max和min的时候 月份没有加1 传入的月份是12时 12大于了11造成的

确实是这样,之前对最大最小限制逻辑做了梳理重构,遗漏掉了

@HeJingWei
Copy link

貌似是因为mMonthSpinner设置max和min的时候 月份没有加1 传入的月份是12时 12大于了11造成的

确实是这样,之前对最大最小限制逻辑做了梳理重构,遗漏掉了

我将月份的MAX和MIN都+1了,这样应该不会有其他问题吧?

@loper7
Copy link
Owner

loper7 commented Jan 25, 2022

我将月份的MAX和MIN都+1了,这样应该不会有其他问题吧?
没问题了,0.5.4 做了这个处理

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants