Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New feature: Resolve DNS names #64

Closed
sjurtf opened this issue Apr 19, 2023 · 4 comments
Closed

New feature: Resolve DNS names #64

sjurtf opened this issue Apr 19, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@sjurtf
Copy link

sjurtf commented Apr 19, 2023

Under the Scan agent settings in phpipam, there are scans that can be enabled.

Screenshot 2023-04-19 at 13 54 37

This provider supports Host Check and Discover new host with these attributes:

include_in_ping        = true
host_discovery_enabled = true

My feature request would be to support the option of enabling resolving of DNS names.

@lord-kyron
Copy link
Owner

@pavel-z1 what do you think? Will this be possible to implement?

@pavel-z1
Copy link
Collaborator

Hi @sjurtf
I checked phpIPAM documentation https://phpipam.net/#subnets
Seems phpIPAM don't have resolveDNS parameter for subnet API controller or this parameter not documented.

If you provide example of phpIPAM API usage which activate resolve DNS names option I guess we could add it.

@sjurtf
Copy link
Author

sjurtf commented Apr 26, 2023

Hi,
you are right - it is missing from the documentation. (Edit: I opened a PR with phpipam/phpipam to add it to the docs)

We are running phpipam 1.5.3 and the resolveDNS is present in the API and it is working as expected when I tested it now.

Working notes:
When I call /api//subnets/ the response includes a field named resolveDNS set to "1" which matched my expectations and the GUI setting.

I tried to modify it with PATCH, and I was able to confirm that it changed the Resolve DNS names setting in the GUI.

curl --request PATCH \
  --url https://<redacted>/api/<appid>/subnets/<subnetid> \
  --header 'Content-Type: application/json' \
  --header 'token: X' \
  --data '{"resolveDNS": "1"}'

@pavel-z1 pavel-z1 self-assigned this Apr 26, 2023
@pavel-z1 pavel-z1 added the enhancement New feature or request label Apr 26, 2023
@pavel-z1
Copy link
Collaborator

Hi @sjurtf
Feature was added in this PR #65

Added subnet parameter - resolve_dns

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants