fixing problems mentioned in PR review #30
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apupier
reviewed
Jun 18, 2024
| @@ -7,11 +7,11 @@ This project is a simple tool to generate a Camel Catalog from a set of Camel co | |||
| Install the project dependencies: | |||
|
|
|||
| ```bash | |||
| mvn install | |||
| mvnw install | |||
There was a problem hiding this comment.
Ah right, otherwise we wouldn't be using the maven wrapper.
apupier
reviewed
Jun 18, 2024
| @@ -126,7 +124,10 @@ public void resolve(MavenDownloader mavenDownloader, String gav, boolean useSnap | |||
| ((KaotoOpenURLClassLoader) getClassLoader()).addURL(ma.getFile().toURI().toURL()); | |||
| } | |||
| } catch (Throwable e) { | |||
| e.printStackTrace(); | |||
| if (getLog()) { | |||
There was a problem hiding this comment.
Don't ask me :D I just aligned to the rest of the codebase. Will leave that to Ricardo.
There was a problem hiding this comment.
Is to use the same log property in both classes (super and current one)
This commit adds a Camel Catalog generator CLI to build the following
structure:
```
dist/
├─ camel-main/
│ ├─ 4.4.0/
│ ├─ 4.6.0/
├─ camel-quarkus/
│ ├─ 3.8.0/
├─ camel-springboot/
│ ├─ 4.4.0/
│ ├─ 4.6.0/
├─ index.json
```
* How to run?
```bash
mvn package; java -jar ./target/catalog-generator-0.0.1-SNAPSHOT.jar -o ./dist -k 4.6.0 -m 4.6.0 -m 4.4.0 -q 3.8.0 -s 4.6.0
```
This will generate:
* Camel Main 4.4.0
* Camel Main 4.6.0
* Camel Quarkus 3.8.0
* Camel SpringBoot 4.6.0
* Usage
```
usage: catalog-generator
-k,--kamelets <kameletsVersion> Kamelets catalog version
-m,--main <version> Camel Main version
-n,--name <catalog library name> Name of the Catalog Library
-o,--output <outputDir> Output directory. It will be cleaned
before generating the catalogs
-q,--quarkus <version> Camel Extensions for Quarkus version
-s,--springboot <version> Camel SpringBoot version
-v,--verbose Be more verbose
```
relates: KaotoIO#1109
Signed-off-by: Lars Heinemann <[email protected]>
lhein
force-pushed
the
feat/generate-catalogs
branch
from
dbf3024 to
60f1eae
Compare
|
no longer needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.