Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-breaking space should map to nbsp by default #99

Closed
lostenderman opened this issue Dec 13, 2022 · 5 comments · Fixed by Witiko/markdown#249
Closed

Non-breaking space should map to nbsp by default #99

lostenderman opened this issue Dec 13, 2022 · 5 comments · Fixed by Witiko/markdown#249
Assignees

Comments

@lostenderman
Copy link
Owner

No description provided.

@Witiko
Copy link
Collaborator

Witiko commented Dec 16, 2022

Can you please assign this issue to me?

@lostenderman
Copy link
Owner Author

Not closing issue with pull #117.

Here is the result of running git checkout commonmark; cd tests; ./test.sh "testfiles/CommonMark_0.30/entity_and_numeric_character_references/001.test":

Testfile testfiles/CommonMark_0.30/entity_and_numeric_character_references/001.test
  Format templates/context/
    Template templates/context/input.tex.m4
      Command texexec  --passon="--shell-escape --8bit --interaction=nonstopmode" test.tex
*** test-expected.log   2023-01-13 18:27:45.157953900 +0100
--- test-actual.log     2023-01-13 18:27:47.897953900 +0100
***************
*** 1,5 ****
  documentBegin
! emphasis: (nbsp) (ampersand) © Æ Ď
  emphasis: ¾ ℋ ⅆ
! emphasis: ∲ ≧̸
  documentEnd
--- 1,5 ----
  documentBegin
! emphasis:   (ampersand) © Æ Ď
  emphasis: ¾ ℋ ⅆ
! emphasis: ∲ (ampersand)ngE;
  documentEnd

@Witiko
Copy link
Collaborator

Witiko commented Jan 13, 2023

@lostenderman My mistake. In Witiko#247, I considered nbsp a character but in UTF-8, it's actually a two-byte string (C2 A0). Should be fixed in Witiko#249. I will open a pull request here after Witiko#249 has been automerged.

@Witiko
Copy link
Collaborator

Witiko commented Jan 13, 2023

@lostenderman #118 should close this issue.

@lostenderman
Copy link
Owner Author

Closing with pull #118.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants