-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lectures
: Add editing functionality to attachment PDF preview
#9265
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All works as expected, implemented on TS2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on TS3. Reapprove
NOTE: Please only test on Non-Chromium Browsers! (Mozilla Firefox, Safari etc.)
NOTE 2: Undefined course problem is fixed in this branch: #9601, please do not mention it here!
Checklist
General
Client
authorities
to all new routes and checked the course groups for displaying navigation elements (links, buttons).Motivation and Context
Currently, in PDF Preview Component, the users are limited to viewing PDFs, but as the related Feature Request mentioned before, for a more interactive and efficient file handling system, there is a need to streamline the process of organizing and editing PDF content without relying on external tools. By introducing advanced file manipulation capabilities, we aim to reduce the time and effort spent on managing PDF files, further enhancing the overall user experience and ensuring consistency within the application. The motivation behind this pull request is to provide users with greater control and flexibility when managing PDF files directly within the Artemis application by providing the most basic functionalities: removing and adding pages to a PDF File.
Implements #8768
Description
This pull request introduces several new features to enhance PDF handling within the Artemis application. The existing PDFPreviewComponent has been upgraded to allow users to interact with PDF files more efficiently. Users can now select individual pages using checkboxes on each thumbnail, enabling multiple pages to be selected for various actions, such as removing or appending new pages. Additionally, users can append pages from other PDF files and save their modifications as a new document. These improvements streamline the process of managing PDF content directly in the application, providing a more flexible and intuitive experience.
NOTE: This PR will be divided into multiple parts in the next PR, it is not in the scope of this PR.
Steps for Testing
Prerequisites:
Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.
Review Progress
Code Review
Manual Tests
Test Coverage
Screenshots
1. General View with new Buttons
2. Delete Page Dialog Box
3. Append File Dialog Box
4. Alerts
Summary by CodeRabbit
Summary by CodeRabbit
New Features
Bug Fixes
Tests