Development: Fix e2e tests for modeling exercises
#9613
Conversation
WalkthroughThe changes in this pull request involve modifications to two classes: Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
src/test/playwright/support/pageobjects/exercises/quiz/DragAndDropQuiz.ts (1)
31-31: Consider making the sidebar element selection more maintainable.While the change from
nth(2)tonth(3)aligns with the PR's objective to fix UML-related E2E tests, using hardcoded indices makes the test fragile and harder to maintain.Consider one of these approaches to make the element selection more robust:
- const classElement = this.page.locator('#modeling-editor-sidebar').locator('div').nth(3); + // Option 1: Use a more specific selector + const classElement = this.page.locator('#modeling-editor-sidebar [data-element-type="class"]'); + // Option 2: Define the index as a named constant + const CLASS_ELEMENT_INDEX = 3; + const classElement = this.page.locator('#modeling-editor-sidebar').locator('div').nth(CLASS_ELEMENT_INDEX);Also, consider adding a comment explaining why this specific index is chosen to help future maintainers understand the context of this change.
src/test/playwright/support/pageobjects/exam/ExamParticipationPage.ts (1)
90-90: LGTM, but document the component numbering.The change aligns with the PR objective of avoiding Package UML elements. However, please add a comment explaining what each component number (2,3,4) represents in the UML model to improve maintainability.
+ // Component numbers represent different UML elements: + // 2: [Please specify the UML element type] + // 3: [Please specify the UML element type] + // 4: [Please specify the UML element type] await this.modelingExerciseEditor.addComponentToModel(exerciseID, 4);
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (2)
- src/test/playwright/support/pageobjects/exam/ExamParticipationPage.ts (1 hunks)
- src/test/playwright/support/pageobjects/exercises/quiz/DragAndDropQuiz.ts (1 hunks)
🔇 Additional comments (1)
src/test/playwright/support/pageobjects/exam/ExamParticipationPage.ts (1)
89-91: Flag: This appears to be a temporary workaround.While this change fixes the immediate issue with Package UML elements, it's worth noting that this is a workaround rather than a proper fix for the freeze issue. Consider creating a follow-up ticket to properly address the root cause of the Package element freeze.
Let's verify the component types being used:
krusche
changed the title
Development: Fix e2e tests that use UMLsDevelopment: Fix e2e tests for modeling exercises
Checklist
General
Client
Motivation and Context
Some of the E2E tests that use Apollon UMLs fail because of Apollon freeze issue when "Package" UML elements are interacted with. This PR changes these tests to not use any "Package" UML elements as a temporary fix.
Description
Changes UML models to not use "Package" elements.
Steps for Testing
Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Review Progress
Code Review
Manual Tests
Summary by CodeRabbit
New Features
Bug Fixes