Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use multicall to batch constant web3 calls in surrogeth-client #15

Open
lsankar4033 opened this issue Sep 26, 2019 · 4 comments
Open

Use multicall to batch constant web3 calls in surrogeth-client #15

lsankar4033 opened this issue Sep 26, 2019 · 4 comments

Comments

@lsankar4033
Copy link
Owner

lsankar4033 commented Sep 26, 2019

https://github.com/makerdao/multicall

Just for constant reads used by the client lib

@barryWhiteHat
Copy link

I belive this will make the transaction simulation more difficult. Imagine i am monirotring the tx pool to see if you have repriced any trnasactions. Without this change I would only need to simulate every transaction that calls 0xrelayer but after this change i would have no way of knowing which transactions eventually call the relayRegistry and i wont know which transactions to simulate unless i do some more advanced analysis

@weijiekoh
Copy link
Contributor

Ah, this isn't about transaction simulation, but for clients (like UIs) to aggregate calls to the registry contract. e.g. instead of making one call per relayerId to get a list of relayerAddress, this library combines all these calls into one which returns an array.

@lsankar4033
Copy link
Owner Author

yep, as @weijiekoh mentioned, this is just for reads (not tx-creating methods)

@barryWhiteHat
Copy link

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants