From 37d9e34d8ad4e4dae0eacdb7b6859f799fb64868 Mon Sep 17 00:00:00 2001 From: Lukas Schneiderbauer Date: Mon, 6 Jan 2025 12:08:56 +0100 Subject: [PATCH] update CRAN comments --- cran-comments.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/cran-comments.md b/cran-comments.md index 01f608a..0954c23 100644 --- a/cran-comments.md +++ b/cran-comments.md @@ -2,8 +2,8 @@ This is a resubmission (after package being archived). -- In this version I have adressed the X-CRAN-Comment and changed 'SystemRequirements' to directly refer to single precision 'fftw3f' and added the optional 'fftw3f_omp' requirement. I also indicated an optional OpenMP requirement. I removed version specifications since they are already implied from the library names. -- The comment "[The package] does not test for [fftwf]" seems incorrect to me: The file ./configure.ac, line #40, contains a paragraph that tests for single precision functions. The configuration fails with a descriptive error message "The fftw3f library is required." in case it does not find a fitting library. I now added additional information to this error message to make it more clear what is missing. I searched the "Writing R Extensions" documentation for additional mandatory places, where a check should occur, to no avail. +- In this version I have addressed the X-CRAN-Comment and changed 'SystemRequirements' to directly refer to single precision 'fftw3f' and added the optional 'fftw3f_omp' requirement. I also indicated an optional OpenMP requirement. I removed version specifications since they are already implied from the library names. +- The note "[The package] does not test for [fftwf]" seems incorrect to me: The file ./configure.ac, line #40, contains a paragraph that tests for single precision functions. The configuration fails with a descriptive error message "The fftw3f library is required." in case it does not find a fitting library. I now added additional information to this error message to make it more clear what is missing. I searched the "Writing R Extensions" documentation for additional mandatory places, where a check should occur, to no avail. - I also added other features, unrelated to the comments, since last submission/archiving. ## R CMD check results @@ -26,4 +26,4 @@ This is a resubmission (after package being archived). - unable to verify current time - - *Remark*: apparently the web service in use is not reachable, the problem seems to be not on my end. + - *Remark*: apparently the web service in use is not reachable, the problem seems not to be on my end.