Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honor $LSCOLORS environment variable #28

Closed
hawkw opened this issue Dec 6, 2018 · 5 comments
Closed

Honor $LSCOLORS environment variable #28

hawkw opened this issue Dec 6, 2018 · 5 comments
Labels
kind/enhancement Enhancement on current feature

Comments

@hawkw
Copy link

hawkw commented Dec 6, 2018

Most shells have an LSCOLORS or LS_COLORS environment variable which allows users to modify which colors are used by LS for different types and states of filesystem objects. It would be excellent if lsd supported this.

@Peltoche
Copy link
Collaborator

Peltoche commented Dec 6, 2018

Hi @hawkw,

This seems an excellent idea! For now I have a focus on some CI/CD stuff but it clearly enter into the todo list.

Do you want to make a contribution and propose a patch?

@hawkw
Copy link
Author

hawkw commented Dec 6, 2018

@Peltoche I don't have a whole lot of spare time right now, but if I have a chance in the near future and nobody else has already done it, I'd be happy to. Just figured it was worth getting it on the to-do list now. :)

@Peltoche Peltoche mentioned this issue Dec 7, 2018
@sharkdp
Copy link
Contributor

sharkdp commented Dec 7, 2018

I have written some Rust code which parses the LS_COLORS environment variable for fd. There is an open ticket to extract that into a separate library/crate here: sharkdp/fd#363. Maybe this could be of use for lsd, too?

@Peltoche Peltoche added the kind/enhancement Enhancement on current feature label Dec 8, 2018
@Skarlett
Copy link

I'll look into forking the repo and seeing if I can merge this feature in.

@Peltoche
Copy link
Collaborator

Hi @Skarlett ,

You should check #84, @meain already work on it. You see with @meain in order to avoid duplicate work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Enhancement on current feature
Projects
None yet
Development

No branches or pull requests

4 participants