Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove date from gemspec #1344

Merged
merged 1 commit into from
Aug 7, 2020
Merged

Remove date from gemspec #1344

merged 1 commit into from
Aug 7, 2020

Conversation

adam12
Copy link
Contributor

@adam12 adam12 commented Jul 17, 2020

Rubygems will automatically set this for us.

Closes #1343

Completed Tasks

  • I have read the Contributing Guide.
  • The pull request is complete (implemented / written).
  • Git commits have been cleaned up (squash WIP / revert commits).
  • I wrote tests and ran bundle exec rake locally (if code is attached to PR).

@adam12
Remove date from gemspec
fd7bfcc 
Rubygems will automatically set this for us.

Closes lsegal#1343
@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.439% when pulling fd7bfcc on adam12:1343-dont-set-date-in-gemspec into d7a16c5 on lsegal:main.

@lsegal lsegal merged commit 2b16190 into lsegal:main Aug 7, 2020
@lsegal
Copy link
Owner

lsegal commented Aug 7, 2020

Thank you!!

lsegal added a commit that referenced this pull request Dec 27, 2020
@lsegal
Tag release v0.9.26
d202e9d 
References:
  #1328, #1331, #1339, #1343, #1344, #1345, #1346, #1347,
  #1363, #1364
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Non-reproducibility issue in packaging
3 participants
@adam12 @coveralls @lsegal