Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update type notation for MethodObject#aliases #1347

Merged
merged 1 commit into from
Aug 7, 2020
Merged

Conversation

thomthom
Copy link
Contributor

@thomthom thomthom commented Aug 7, 2020

Description

I was generating some stubs from the Yard database, and doing by the docs I thought MethodObject#aliases returned an array of Symbol, but the output included the fully qualified name. Upon inspection I found that the method actually returns an array of MethodObject.

Completed Tasks

  • I have read the Contributing Guide.
  • The pull request is complete (implemented / written).
  • Git commits have been cleaned up (squash WIP / revert commits).
  • I wrote tests and ran bundle exec rake locally (if code is attached to PR).

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.439% when pulling 5e1dc6b on thomthom:patch-1 into d7a16c5 on lsegal:main.

@lsegal lsegal merged commit 27a4752 into lsegal:main Aug 7, 2020
@lsegal
Copy link
Owner

lsegal commented Aug 7, 2020

Thanks for the quick fix!

@thomthom
Copy link
Contributor Author

thomthom commented Aug 8, 2020

It's so easy when GitHub makes the process of creating a dev branch in my fork in a single click and the offer an online editor to make the change. Drive-by-PR! :D

@thomthom thomthom deleted the patch-1 branch October 21, 2020 10:47
lsegal added a commit that referenced this pull request Dec 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants